Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow Reclaim of ITC Reversal (backport #3115) #3119

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Allow Reclaim of ITC Reversal (backport #3115) #3119

merged 2 commits into from
Mar 4, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 3, 2025

closes: #3114

This is an automatic backport of pull request #3115 done by Mergify.

@Ninad1306 @mergify
fix: allow reclaim of itc through journal entry
fc98815 
(cherry picked from commit d28ac00)

# Conflicts:
#	india_compliance/patches.txt
@mergify mergify bot added the conflicts label Mar 3, 2025
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Mar 3, 2025

Cherry-pick of d28ac00 has failed:

On branch mergify/bp/version-14-hotfix/pr-3115
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit d28ac00a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   india_compliance/gst_india/doctype/gstr_3b_report/gstr_3b_report.html
	modified:   india_compliance/gst_india/doctype/gstr_3b_report/gstr_3b_report.py
	modified:   india_compliance/gst_india/setup/property_setters.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   india_compliance/patches.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: IC-3248

@vorasmit vorasmit removed the conflicts label Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.70%. Comparing base (698b39a) to head (545e7dd).
Report is 10 commits behind head on version-14-hotfix.

Files with missing lines Patch % Lines
...gst_india/doctype/gstr_3b_report/gstr_3b_report.py 76.92% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-14-hotfix    #3119      +/-   ##
=====================================================
+ Coverage              60.69%   60.70%   +0.01%     
=====================================================
  Files                    116      116              
  Lines                  11259    11267       +8     
=====================================================
+ Hits                    6834     6840       +6     
- Misses                  4425     4427       +2
Files with missing lines Coverage Δ
...dia_compliance/gst_india/setup/property_setters.py 41.17% <ø> (ø)
...gst_india/doctype/gstr_3b_report/gstr_3b_report.py 84.59% <76.92%> (-0.24%) ⬇️

Impacted file tree graph

@mergify mergify bot merged commit b4f0865 into version-14-hotfix Mar 4, 2025
13 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-3115 branch March 4, 2025 01:37
@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 14.30.17 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ninad1306 Ninad1306

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@india-compliance-bot @vorasmit @Ninad1306